Add line layout cache with rendering regression tests#449
Draft
leftspin wants to merge 6 commits intomigueldeicaza:mainfrom
Draft
Add line layout cache with rendering regression tests#449leftspin wants to merge 6 commits intomigueldeicaza:mainfrom
leftspin wants to merge 6 commits intomigueldeicaza:mainfrom
Conversation
Contributor
Author
|
Just PR’ing as a heads up. Currently testing in my visionOS remote term app. Getting improve fps and lower latency especially with tmux panes. |
added 6 commits
January 20, 2026 11:23
- Restore accidentally deleted iOS Package.resolved - Remove diagnostic print statement from cache hit rate test
acccbe0 to
13f18c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LineLayoutCacheto cacheCTLineobjects andViewLineInfoper buffer row, avoiding repeatedCTLineCreateWithAttributedStringcalls for unchanged linesRenderingStrategyenum (.legacy,.cached) with runtime toggle viarenderingStrategypropertyLineLayoutCacheMetrics) for observabilityTest coverage
LineLayoutCacheTests- cache hits/misses, invalidation, generation trackingRenderingStrategyTests- strategy switching, visual equivalenceTerminalUpdateRangeTests- dirty region trackingViewLineInfoTests- line info constructionExpected performance characteristics
less,git log)top,htop)The cache keys on absolute
bufferRow, not screen position, so viewport scrolling without content changes yields cache hits on revisited lines.TODO